Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMU sensors - Include alljoints-inertials_wrapper/remapper in YRI xml files #640

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

martinaxgloria
Copy link
Contributor

As pointed out by @traversaro here, the files that expose via multipleanalogsensorsremapper the orientation measurements of the available IMUs are now included in the XML used by the yarprobotinterface

This PR will complete #636

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martinaxgloria
CI is failing.

@martinaxgloria
Copy link
Contributor Author

Probably I'm missing some configuration files, I'll take a look into

@martinaxgloria
Copy link
Contributor Author

As expected, the CI was falling due to some missing configuration files. Moreover, I noticed that the dry-run checks only the XML that the YRI uses by default, that is the one under yarprobotinterface.ini. Since for the other XML there's no CI check (for example, for ergocub_wbd.xml or for ergocub_all_ros2.xml, but also some iCubs have more than one YRI launch file), what about adding the alljoints-inertials_wrapper/remapper only in the main yarprobotinterface XML file? Or are there other files that are used and that could be worth manually maintaining them?

cc @traversaro @Nicogene @pattacini

@traversaro
Copy link
Member

Ok, I think I did not get your question.

@martinaxgloria
Copy link
Contributor Author

Aligned with @traversaro t2t, we decided to expose IMU measurements only in the yri default xml for the iCubs, while for ergoCubSN001 and ergoCubSN002 in all ergocub_*.xml.

cc @Nicogene @pattacini

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps for the fix, @martinaxgloria 🚀

@pattacini pattacini merged commit c6a2982 into robotology:master Apr 12, 2024
1 check passed
@martinaxgloria martinaxgloria deleted the patch-1 branch April 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants