-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup yarprobotinterface conf files for ergoCub #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks heaps @traversaro 👍🏻
cc @Nicogene @martinaxgloria @davidetome @valegagge @marcoaccame @AntonioConsilvio @MSECode @mfussi66
Ok! Let's get rid of it and monitor the situation.
Agree 👍🏻 |
fyi @S-Dafarra @GiulioRomualdi as it was added in #616 |
In case it is actually needed, we're required to deal with ergoCubSN002 as well via a new PR. |
It is needed to avoid high bandwidth usage when performing remote teleoperation. We have a module on the operator side connecting to that control board only, so we added another wrapper running at low frequency |
Ok then. I'll reinstate #616 and duplicate it for ergoCubSN002. |
Fix #641 .
The changes in the PR are the one described in #641 (comment) . I actually used the same ergocub.xml for all ergoCub robots, with the following differences:
robot name=
attribute.ergoCubSN00
, the following lines are commented:I am not sure why this happening, but to avoid regression I left these lines commented also in the new
ergocub.xml
ergoCubSN001
, there was also a<xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" />
line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.To avoid regressions, this PR does not remove any existing
ergocub_***.xml
files. Once the newergocub.xml
are tested and working, we can remove theergocub_***.xml
files in a follow up PR.