Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup yarprobotinterface conf files for ergoCub #645

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

traversaro
Copy link
Member

Fix #641 .

The changes in the PR are the one described in #641 (comment) . I actually used the same ergocub.xml for all ergoCub robots, with the following differences:

  • Each robot, has a different robot name= attribute.
  • In ergoCubSN00, the following lines are commented:
    <!-- BATTERY BAT -->
    <!-- <xi:include href="wrappers/battery/battery_bat.xml" /> -->
    <!-- <xi:include href="hardware/battery/battery_bat.xml" /> -->

I am not sure why this happening, but to avoid regression I left these lines commented also in the new ergocub.xml

  • In ergoCubSN001, there was also a <xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" /> line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

To avoid regressions, this PR does not remove any existing ergocub_***.xml files. Once the new ergocub.xml are tested and working, we can remove the ergocub_***.xml files in a follow up PR.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pattacini
Copy link
Member

In ergoCubSN001, there was also a <xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" /> line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

Ok! Let's get rid of it and monitor the situation.

To avoid regressions, this PR does not remove any existing ergocub_.xml files. Once the new ergocub.xml are tested and working, we can remove the ergocub_.xml files in a follow up PR.

Agree 👍🏻
I'll open a follow-up issue for the cleanup.

@pattacini pattacini merged commit 995badf into robotology:devel Apr 21, 2024
1 check passed
@traversaro
Copy link
Member Author

In ergoCubSN001, there was also a <xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" /> line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

fyi @S-Dafarra @GiulioRomualdi as it was added in #616

@pattacini
Copy link
Member

In ergoCubSN001, there was also a <xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" /> line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

fyi @S-Dafarra @GiulioRomualdi as it was added in #616

In case it is actually needed, we're required to deal with ergoCubSN002 as well via a new PR.

@S-Dafarra
Copy link
Contributor

In ergoCubSN001, there was also a <xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" /> line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

fyi @S-Dafarra @GiulioRomualdi as it was added in #616

It is needed to avoid high bandwidth usage when performing remote teleoperation. We have a module on the operator side connecting to that control board only, so we added another wrapper running at low frequency

@pattacini
Copy link
Member

It is needed to avoid high bandwidth usage when performing remote teleoperation. We have a module on the operator side connecting to that control board only, so we added another wrapper running at low frequency

Ok then. I'll reinstate #616 and duplicate it for ergoCubSN002.

@pattacini
Copy link
Member

Ok then. I'll reinstate #616 and duplicate it for ergoCubSN002.

Done via #647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup ergocub configuration files using enable_by and disable_by yarprobotinterface tags
3 participants