Skip to content

Commit

Permalink
Switch to generate YARP idl files at every build to fix compatibility…
Browse files Browse the repository at this point in the history
… with YARP master (#131)

While working on robotology/robotology-superbuild#900, I had problems with the idl generated files, as the one generated with YARP 3.5 (I guess) had problems to be compiled with YARP master. To avoid the problem at the root, I switched to generate the idl files at each build (instead of committing them manually) and I removed the autogenerated files that at the moment were committed in the repo. This was done by just generating the idl files in the build directory instead of the source directory.

* Switch to generate YARP idl files at every build

* update changelog

Co-authored-by: Hosameldin Mohamed <[email protected]>
  • Loading branch information
traversaro and HosameldinMohamed authored Nov 23, 2021
1 parent 64b513c commit 7453ac4
Show file tree
Hide file tree
Showing 24 changed files with 6 additions and 8,739 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- Fixed joint acceleration filtering (See [!124](https://github.com/robotology/whole-body-estimators/pull/124)).
- Fixed `wholeBodyDynamics` device when loaded by the `gazebo_yarp_robotinterface` Gazebo plugin [!126](https://github.com/robotology/whole-body-estimators/issues/126)
- Fixed `wholeBodyDynamics` device when loaded by the `gazebo_yarp_robotinterface` Gazebo plugin [!126](https://github.com/robotology/whole-body-estimators/issues/126).
- Switch to generate YARP idl files at every build to fix compatibility with YARP master [!131](https://github.com/robotology/whole-body-estimators/pull/131).

### Changed
- Always enable compilation of devices (See [!115](https://github.com/robotology/whole-body-estimators/pull/115))
- Migrate from `RateThread` to `PeriodicThread` in WholeBodyDynamics device (See [!130](https://github.com/robotology/whole-body-estimators/pull/130)).
Expand Down
2 changes: 1 addition & 1 deletion idl/floatingBaseEstimatorRPC/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# CopyPolicy: Released under the terms of the LGPLv2.1 or later, see LGPL.TXT

yarp_idl_to_dir(INPUT_FILES codyco/floatingBaseEstimatorRPC.thrift
OUTPUT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/autogenerated
OUTPUT_DIR ${CMAKE_CURRENT_BINARY_DIR}/autogenerated
SOURCES_VAR WBDIDLSERVER_SRC
HEADERS_VAR WBDIDLSERVER_HEADERS
INCLUDE_DIRS_VAR WBDIDLSERVER_INCLUDES)
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 7453ac4

Please sign in to comment.