Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pydantic v2 #212

Open
auscompgeek opened this issue Sep 3, 2023 · 5 comments
Open

Upgrade to pydantic v2 #212

auscompgeek opened this issue Sep 3, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@auscompgeek
Copy link
Member

#207 pins pydantic to v1. We should upgrade. There's a migration guide in their docs: https://docs.pydantic.dev/latest/migration/

Note that we'll need to build pydantic_core in https://github.com/robotpy/roborio-wheels, which means we'll need to get Rust into the cross-build container (https://github.com/robotpy/robotpy-cross-docker) too.

@auscompgeek auscompgeek added the enhancement New feature or request label Sep 3, 2023
@virtuald
Copy link
Member

virtuald commented Sep 3, 2023

That feels like a lot of work for low reward, but if you can figure out how to make it work I'm happy to accept the changes.

@virtuald
Copy link
Member

virtuald commented Sep 3, 2023

Sorry, I didn't realize this was for robotpy-build... why do we need to upgrade pydantic in roborio-wheels? I no longer use robotpy-build natively, we exclusively use crossenv in docker now.

@TheTripleV
Copy link
Member

Pydantic v2 versions apparently ship with v1 embedded in it. So we could use that

@auscompgeek
Copy link
Member Author

pydantic-core is written in Rust, so we should have it prebuilt to avoid building it in all of our CI jobs, right? Or am I misunderstanding how our cross-builds work?

@virtuald
Copy link
Member

virtuald commented Sep 4, 2023

The cross build has a native piece and a cross piece. robotpy-build runs in the native side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants