Set correct pull request message for --dry-run case #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes Nix package generation nearly 4 times faster, if tarballs are already cached. Some of the optimizations also apply to other distros, but the performance impact there was not tested.
GitLab returns a 403 error if the default urllib user agent is used.
This allows conditions in package.xml to be evaluated correctly. Mostly copied from the Bitbake generator.
This is required to make strictDeps/cross-compilation work.
This name better represents what this class does, which is to generate the actual text of a Nix expression for a package.
The license translation logic has changed, and adds a hyphen to unknown licenses. Also, add a test for the public domain license.
When --all is specified, generate for rolling as well.
The license string in the generated nix package file was broken when the license name contained quote. It has been fixed. Backslash and the sequence "dollar opening bracket" have been escaped too.
Use the same function to escape the description string as is used for the license string.
When --only is used, if --dry-run is used it calls save_pr() otherwise file_pr() is called. This ensures that the same string value is passed to the delta parameter of both functions. Signed-off-by: Rob Woolley <[email protected]>
robwoolley
force-pushed
the
nixos-support
branch
from
9c7897e to
8063140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --only is used, if --dry-run is used it calls save_pr() otherwise file_pr() is called. This ensures that the same string value is passed to the delta parameter of both functions.