Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes, mostly graphical #165

Merged
merged 24 commits into from
Mar 19, 2020
Merged

Various changes, mostly graphical #165

merged 24 commits into from
Mar 19, 2020

Conversation

robx
Copy link
Owner

@robx robx commented Mar 18, 2020

This has a couple of straightforward and a couple of rather experimental changes.

  • reword a lot of error messages, to get rid of "plural" mostly
  • fix the shakashaka triangle drawing to align short triangle edges with given shaded cells
  • use devicePixelRatio when available to
    1. draw grid lines with a width that's a multiple of actual pixel size
    2. draw grid lines with width below 1 at low resolutions on high dpi displays
  • change the dashing count to a minimum of 4 (from 3 before)
  • draw the chassis (frame around the puzzle) towards the outside, instead of centered; this should mean that cells next to the edge of the grid are more square; e.g. noticably masyu clues will appear less close to the edge

This PR is live for testing at https://garp.vllmrt.net/scratch/various.

Todo:

  • loops (drawn with width lw) sometimes aliase to different widths vertically versus horizontally, particularly at low cell sizes

@robx
Copy link
Owner Author

robx commented Mar 19, 2020

I've split out two non-ready features (line width and chassis) into #166 and #167.

@robx robx merged commit 67eeb33 into master Mar 19, 2020
@robx robx deleted the various branch March 19, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant