Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start of ES6 modules: move to rollup #183
base: main
Are you sure you want to change the base?
start of ES6 modules: move to rollup #183
Changes from 9 commits
02bca34
5a51d4a
a91ebd2
1a183a3
da17a11
5ab22fd
38c2637
2428e8c
d3f688a
1e68e0e
b8d87b4
3a5601f
e68fe02
96df19d
e15d00c
3c68511
4d9ea3a
8189d2f
da65ab1
a893dc5
b790892
f4a992e
6f61769
64b5740
f296cba
de8b52b
2d040e8
8e2a468
5f9d9a9
a01fadf
88b5026
3bd5a16
93ba59f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the git-hash part here seems like it should be redundant with the new Makefile target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we get rid of this script entirely and call
npx grunt default
from the Makefile instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.html and the examples and such are still copied with Grunt. I thought is was a bit too much to also change that in this PR. But we could.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean to get rid of Grunt, I meant to get rid of the
"build"
script inpackage.json
, and to call Grunt directly from the Makefile.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this (still) used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's referenced in Gruntfile:
But the only difference seems to be that if PRODUCTION is true it copies over .map files, which is fine anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's at least fine in the sense that I'm currently deploying those anyway... https://puzz.link/js/list.js.map
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.