-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Task as a built-in module/type #6836
Open
smores56
wants to merge
27
commits into
roc-lang:main
Choose a base branch
from
smores56:builtin-task
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smores56
commented
Jun 25, 2024
smores56
commented
Jun 25, 2024
It looks like there is a genuine issue with the False interpreter.
|
|
TODO: rename |
TODO from Richard:
|
ayazhafiz
reviewed
Aug 2, 2024
ayazhafiz
reviewed
Aug 2, 2024
ayazhafiz
reviewed
Aug 2, 2024
ayazhafiz
reviewed
Aug 2, 2024
ayazhafiz
reviewed
Aug 2, 2024
ayazhafiz
reviewed
Aug 2, 2024
ayazhafiz
reviewed
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the
Task
opaque IO type from platform-specific implementations to the standard library of Roc. This PR is ready for review, barring final testing by building a pre-release ofbasic-cli
using the twin basic-cli PR. The high level changes are:Task
module from the basic-cli platform tocrates/compiler/builtins/roc/Task.roc
Task
andEffect
into just theTask
opaque type with definitionTask ok err := {} -> Result ok err
, which is the old type forEffect a : {} -> a
thatTask ok err : Effect (Result ok err)
wrappedEffect
generation code, as everything should useTask
directlygenerates Effect with [after, map, ...]
clause of the hosted module header, which is a breaking changeRocResult
s now, and FFI type declarations on the Roc side need to always haveTask
return typesEffect.after
,Effect.map
, etc. functions as they were needed to glueEffect
toTask
, but are no longer needed now that those types have been combinedEffect.roc
toPlatformTask.roc
to distinguish their behavior from the old approach and to give a name more descriptive of the new behaviorbasic-cli
works, that is on hold