PR #8207 without snapshot changes #8236
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtfeldman
force-pushed
the
new-changes-diff
branch
from
3759ffd to
3a339ce
Compare
rtfeldman
force-pushed
the
new-changes-diff
branch
4 times, most recently
from
e1b66bd to
33a6d5d
Compare
rtfeldman
force-pushed
the
new-changes-diff
branch
4 times, most recently
from
2be7253 to
76b0de4
Compare
rtfeldman
force-pushed
the
new-changes-diff
branch
from
76b0de4 to
4bc4550
Compare
rtfeldman
force-pushed
the
new-changes-diff
branch
from
4bc4550 to
d385ecc
Compare
FabHof
reviewed
Sep 16, 2025
| }, | ||
| '0'...'9' => return try self.tokenizeNumber(self.gpa, start), | ||
| '/' => return chompOneOfTwo(&self.pos, src, '/', .OpSlash, .OpDoubleSlash), | ||
| '-' => return chompOneOfTwo(&self.pos, src, '>', .OpBinaryMinus, .OpThinArrow), // TODO handle unary minus here by checking for preceding whitespace |
There was a problem hiding this comment.
I was curious about your rework and came across this comment. Just my two cents: If a-b should be the same as a - b, then whitespace is not the right way to distinguish between binary and unary minus.
This is probably not that relevant in the grand scheme of this rework. Just a small thing I noticed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With snapshot changes, the diff on #8207 is too gigantic to be reviewable. This branch is just to have a smaller diff to work with!