New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in tag.py #116

Merged

ortex merged 1 commit into roc-streaming:main from gavv:main

Sep 30, 2023

Member

gavv commented Sep 30, 2023

Changes:

Fix error
Show status
Sort imports

Error was:

./tag.py --push origin v0.2.2
--- Updating version in roc/version.go to 0.2.2
Traceback (most recent call last):
  File "/home/victor/dev/roc-streaming/roc-go/./tag.py", line 91, in <module>
    main()
  File "/home/victor/dev/roc-streaming/roc-go/./tag.py", line 84, in main
    commit_change(version, force)
TypeError: commit_change() takes 1 positional argument but 2 were given


          Fix in tag.py

gavv requested a review from ortex

September 30, 2023 09:07

ortex approved these changes

View reviewed changes

Collaborator

coveralls commented Sep 30, 2023

coverage: 95.037%. remained the same when pulling 7497627 on gavv:main into 963cc75 on roc-streaming:main.

ortex merged commit 5f72459 into roc-streaming:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet