Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update something #11

Merged
merged 6 commits into from
Jun 19, 2018
Merged

Update something #11

merged 6 commits into from
Jun 19, 2018

Conversation

realdennis
Copy link
Contributor

  • Dependency a temporary arpjs (work around for node v10)
    (cause node_pcap and socketwatcher some namespace error in v10?)
    watch this and this

  • Remove broken badge (bitHound)

  • Add greenkeeper and remove nsp to keep the dependencies newest and safe

  • Add osx enviroment for travis

  • Some code style change for standard latest version auto fix

realdennis and others added 6 commits June 16, 2018 08:08
@roccomuso roccomuso merged commit ed3dd46 into roccomuso:master Jun 19, 2018
@roccomuso
Copy link
Owner

@realdennis does it works for you after the merge?

@realdennis
Copy link
Contributor Author

Hey, I thought the root cause about Node v10 is the node_pcap(namespace error & depend old socketwatcher) but it fixed after merge 243

In this repo's(kickthemout) pull request, I just remove broken badge, update some dependencies and add Greenkeeper(but you need to open it).

Greenkeeper continuous check project's dependencies version and tell you CI result.
(You can merge it when build pass.) Like this.

By the way, I thought we need to write more test case to keep a robust CI not just check coding style.

@roccomuso
Copy link
Owner

roccomuso commented Jun 19, 2018

Yeah, PRs are welcome. I had no time to write tests.

Btw right now the inquirer selection is stuck when i run it with node 8. Are you having the same issue?

@realdennis
Copy link
Contributor Author

I don't have this issue in Node v8, but I found that Inquirer.js doesn't support version under Node v6, I am sorry to aware it too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants