Make pandas optional dependency #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2018 18:59
Importing pandas/numpy can be slow (it doubles the startup time of ./manage.py, and some people reports that pandas takes seconds to load), and it's a pretty huge dependency for a functionality that is already in the standard library. Making it an optional dependency makes it easy for people to gain pandas speedup while not incurring the cost for those who don't need it.
This assumes Python 3, but the code is already broken on Python 2 anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas/numpy can be very slow to import, in some cases it takes multiple seconds to import pandas and it's also a huge library with a huge dependency on numpy, which can be a pain to install if you don't have binary package. This change makes panda an extra dependency so django-csv-exports can automatically use it when it's available, but otherwise use standard library csv module, and to load pandas lazily so it doesn't slow down running unrelated ./manage.py commands when the user has django-csv-exports installed in INSTALLED_APPS.