-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Exports and Imports #454
Add New Exports and Imports #454
Conversation
…ort, and export global agents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phalestrivir can you check if the file starting with capital F is the final one or the one with lower-case f?
Since both files are in git but only one can exist on a filesystem, it creates a weird conflict. I just don't know which one to delete and which one to keep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phalestrivir can you check if the file starting with capital F is the final one or the one with lower-case f?
Since both files are in git but only one can exist on a filesystem, it creates a weird conflict. I just don't know which one to delete and which one to keep.
@phalestrivir since we released v3.0.0 of the lib, you could, if you want, update the Regarding the issue with these two files: I've had that happen when I renamed files but the only change was the case of a character in the filename and then I just did a git add, it leads to this conflict. There is a |
@vscheuber I just updated the package.json to the latest lib version 3.0.1-0. I deleted the Federation.authenticationModules.json file. It wasn't a renaming issue, but rather there was an authentication module named Federation in the frodo dev tenant that was being exported in addition to the default federation module, so they were two separate, distinct modules. I went ahead and deleted it from the dev tenant since it doesn't appear to be used anywhere so that way in future exports we don't run into the same problem. |
c6f2957
to
441dd81
Compare
@vscheuber It seems the checks are failing because it can't find the newest changes to the library code. Both package.json and package-lock.json are updated to the latest version of the lib, so I'm not sure what else is causing it to fail. |
This PR contains changes to allow for the addition of new imports and exports in Frodo Lib (see this PR. The changes are all separated in separate commits, and they include:
role
command which allows for listing, exporting, and importing internal roles.server
command which allows for listing, exporting, and importing servers and their corresponding properties and default properties.realm
command to add export and import functionality for realms.