meson: simplify python3 detection #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't look up the python module's find_installation() method. This is
intended for detecting lots of information needed for compiling and
installing python modules including the C-API interface to libpython, as
well as site-packages layout information.
It's totally uninvolved with what we are doing, which is executing a
script. For this, we just need any python program. Meson is written in
python3, so we know in meson.build that we have that available -- which
is also why meson guarantees that `find_program('python3')` always
returns a valid python. Even if no python is installed on the system,
meson will return the `meson.exe runpython` shim which runs the script
using the copy of python bundled inside the redistributable meson
Windows executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't look up the python module's find_installation() method. This is intended for detecting lots of information needed for compiling and installing python modules including the C-API interface to libpython, as well as site-packages layout information.
It's totally uninvolved with what we are doing, which is executing a script. For this, we just need any python program. Meson is written in python3, so we know in meson.build that we have that available -- which is also why meson guarantees that
find_program('python3')always returns a valid python. Even if no python is installed on the system, meson will return themeson.exe runpythonshim which runs the script using the copy of python bundled inside the redistributable meson Windows executable.