Support json arrays #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbaldwin-rs
force-pushed
the
sbaldwin_json_array_support
branch
from
0f136fb to
de7031d
Compare
sbaldwin-rs
force-pushed
the
sbaldwin_json_array_support
branch
from
de7031d to
c9d4332
Compare
|
Just tested to confirm this works. The _id don't conflict because each batch is assigned an _id, then a suffix is used to denote the position in the list of the batch write. |
abbccdda
reviewed
Apr 11, 2022
| @@ -70,10 +71,7 @@ public Map<String, Object> parseValue(SinkRecord record) { | |||
| log.warn(message, cause); | |||
| throw new RuntimeException(message, e); | |||
| } | |||
|
|
|||
| int size = maps.size(); | |||
| checkArgument(size == 1, "Only 1 object allowed in list type messages. Found %s", size); | |||
There was a problem hiding this comment.
Just curious, why do we even have this constraint before?
There was a problem hiding this comment.
An additional backend change is required if there is more than one document in the payload.
sudhindra-rockset
approved these changes
Apr 12, 2022
|
I will hold off on merging until backend changes are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for parsing JSON arrays with multiple values