Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lxml dep #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add lxml dep #1

wants to merge 1 commit into from

Conversation

sbaldwin-rs
Copy link
Collaborator

No description provided.


python_version = "PY3"


py_binary(
name = "pomgen",
srcs = [":pomgen_files"],
deps = [requirement("lxml")],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing is off, but not a functional issue

@@ -25,6 +27,7 @@ py_binary(
name = "update",
main = "update.py",
srcs = [":pomgen_files"],
deps = [requirement("lxml")],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link

@morganda morganda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants