Skip to content

Commit

Permalink
Force _event_time to be a datetime type
Browse files Browse the repository at this point in the history
Summary
It makes things so much easier in applications like superset because the
column is properly used.

Test plan

Changed the type, created a new wheel and used it in superset

Reviewers: haneeshr
  • Loading branch information
mpatou committed Mar 4, 2024
1 parent 8530127 commit 859f859
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/rockset_sqlalchemy/sqlalchemy/dialect.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ def _get_table_columns(self, connection, table_name, schema):
field_type, fields[0], schema, table_name
)
)
if field[0] == "_event_time":
field_type = "timestamp"
columns.append(
{
"name": field[0],
Expand Down

0 comments on commit 859f859

Please sign in to comment.