update dialect to get columns based on DESCRIBE #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review this shortly |
sbaldwin-rs
reviewed
May 30, 2024
| @@ -15,16 +15,14 @@ | |||
| entry_points={ | |||
| "sqlalchemy.dialects": [ | |||
| "rockset_sqlalchemy = rockset_sqlalchemy.sqlalchemy:RocksetDialect", | |||
| "rockset = rockset_sqlalchemy.sqlalchemy:RocksetDialect" | |||
| "rockset = rockset_sqlalchemy.sqlalchemy:RocksetDialect", | |||
There was a problem hiding this comment.
The version needs to be bumped, right?
sbaldwin-rs
reviewed
May 30, 2024
| @@ -115,10 +116,72 @@ def _get_table_columns(self, connection, table_name, schema): | |||
| raise e | |||
| return columns | |||
|
|
|||
| def _validate_query(self, connection: Engine, query: str): | |||
| import rockset.models | |||
There was a problem hiding this comment.
Any reason not to have this import at the top of the file?
sbaldwin-rs
reviewed
May 30, 2024
| if not isinstance(max_field_depth, int): | ||
| raise ValueError("Query option max_field_depth, must be of type 'int'") | ||
|
|
||
| q = f"DESCRIBE {table_name} OPTION(max_field_depth={max_field_depth})" |
There was a problem hiding this comment.
The schema needs to be in the DESCRIBE query, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This attempts to fix #19
Currently, if you try to fetch the columns of the table, it will
select * from collection limit 1which assumes a fixed schema.This PR adds a version of this implementation, but instead uses
describe collection option(max_field_depth=1)wheremax_field_depthis configurable. There are two minor caveatsdescribemethod, does not return the_metafield whereas theselectmethod would.describeso if aRocksetExceptionis thrown, it will fall back to theselectmethod. The format of the response is the same so there shouldn't be too many surprises.Misc
Tests