Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock-on install wizard obfuscates share container info #2886 #2888

Conversation

phillxnet
Copy link
Member

@phillxnet phillxnet commented Aug 15, 2024

Ensure Rock-on install wizard maintains container awareness re requested Share mapping. Enabling more robust back-end Share to container volume mapping in multi-container Rock-ons.

Fixes #2886

Testing

Issue detailed multi-container reproducer Rock-on (in Draft PR) successfully mapped two different containers with the same internal volume mapping /etc/bareos to two different Shares:

Requested Share:Volume mapping:

Rock-on-pre-install-summary-shares

Resulting Share:Volume mapping:

Rock-on-installed-summary-shares


Prior to the proposed changes, both /etc/bareos volume mappings from the two different containers in the reproducer Rock-on were inadvertently mapped to the last Share specified against a container volume of /etc/bareos. As described in the linked issue.

Linking to a recent (now merged) parallel fix for Rock-on environment elements: #2887

Ensure Rock-on install wizard maintains container awareness re
requested Share mapping. Enabling more robust back-end Share to
container volume mapping in multi-container Rock-ons.
@phillxnet
Copy link
Member Author

docker inspect confirmation

For the installed reproducer Rock-on we have the following confirmed volumes mapped to host Shares:

bareos-director

docker inspect bareos-director
...
        "Mounts": [
            {
                "Type": "bind",
                "Source": "/mnt2/bareos-dir-config",
                "Destination": "/etc/bareos",
                "Mode": "",
                "RW": true,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Source": "/etc/localtime",
                "Destination": "/etc/localtime",
                "Mode": "ro",
                "RW": false,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Source": "/mnt2/bareos-catalog-backup",
                "Destination": "/var/lib/bareos",
                "Mode": "",
                "RW": true,
                "Propagation": "rprivate"
            }
        ],
...
            "Image": "barcus/bareos-director:latest",
            "Volumes": {
                "/etc/bareos": {},
                "/var/lib/bareos": {}
            },

bareos-storage

docker inspect bareos-storage
...
        "Mounts": [
            {
                "Type": "bind",
                "Source": "/mnt2/bareos-backups",
                "Destination": "/var/lib/bareos/storage",
                "Mode": "",
                "RW": true,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Source": "/mnt2/bareos-storage-config",
                "Destination": "/etc/bareos",
                "Mode": "",
                "RW": true,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Source": "/etc/localtime",
                "Destination": "/etc/localtime",
                "Mode": "ro",
                "RW": false,
                "Propagation": "rprivate"
            }
        ],
...
            "Image": "barcus/bareos-storage:latest",
            "Volumes": {
                "/etc/bareos": {},
                "/var/lib/bareos/storage": {}
            },

I.E. (Share:container_vol)

  • bareos-director container has /mnt2/bareos-dir-config:/etc/bareos
  • bareos-storage container has /mnt2/bareos-storage-config:/etc/bareos

Where-as these were, previous to the proposed changes, both mapped to /mnt2/bareos-storage-config as detailed in #2886 (comment)

@phillxnet phillxnet merged commit 22614e7 into rockstor:testing Aug 19, 2024
@phillxnet phillxnet deleted the 2886-Rock-on-install-wizard-obfuscates-share-container-info branch August 19, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant