Adapt to coq/coq#17667 (handle genarg in patterns) #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
reviewed
Oct 11, 2023
| @@ -36,6 +36,22 @@ type case_info_pattern = | |||
|
|
|||
| let hash_fold_array = hash_fold_array_frozen | |||
|
|
|||
| (** Can't properly serialize this GADT | |||
| Currently we only expose the derives for constr_pattern so can't occur anyway. | |||
There was a problem hiding this comment.
Note that if that gets exposed in the future, people will get weird errors on the Ast; up to you, but maybe worth piercing instead, getting the Coq Ast is the main use case of SerAPI these days so I'm wary this could affect lots of ppl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.