Merge into prod #65
Merged
Merge into prod #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]>
Change fspName to programFinancialServiceProviderConfigurationName in test
Signed-off-by: Ruben <[email protected]>
…-url Changed endpoint url path post registrations
Remove nlrc exceptions
tijsziere
added a commit
that referenced
this pull request
Jan 22, 2025
* Merge into prod (#65) * merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * Removed included from export * change test accordingly * also remove phoneNumber from payment export, fix tests * remove print --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: tijsziere <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]>
tijsziere
added a commit
that referenced
this pull request
Jan 22, 2025
* merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions * Included not in payment export (#66) * Merge into prod (#65) * merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * Removed included from export * change test accordingly * also remove phoneNumber from payment export, fix tests * remove print --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: tijsziere <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> Co-authored-by: Wessel de Jong <[email protected]>
tijsziere
added a commit
that referenced
this pull request
Jan 22, 2025
* merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions * Included not in payment export (#66) * Merge into prod (#65) * merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * Removed included from export * change test accordingly * also remove phoneNumber from payment export, fix tests * remove print --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: tijsziere <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * better error handling * improve error handling, remove unnecessary checkfields * catch date errors * change to programRegistrationAttributes * update programQuestions to programRegistrationAttribute * update 121 route * re-add fspName * update test --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> Co-authored-by: Wessel de Jong <[email protected]>
tijsziere
added a commit
that referenced
this pull request
Jan 22, 2025
* merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions * Included not in payment export (#66) * Merge into prod (#65) * merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * Removed included from export * change test accordingly * also remove phoneNumber from payment export, fix tests * remove print --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: tijsziere <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * better error handling * improve error handling, remove unnecessary checkfields * catch date errors * change to programRegistrationAttributes * update programQuestions to programRegistrationAttribute * update 121 route * re-add fspName * update test * update --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> Co-authored-by: Wessel de Jong <[email protected]>
tijsziere
added a commit
that referenced
this pull request
Jan 22, 2025
* merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions * Included not in payment export (#66) * Merge into prod (#65) * merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * Removed included from export * change test accordingly * also remove phoneNumber from payment export, fix tests * remove print --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: tijsziere <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * better error handling * improve error handling, remove unnecessary checkfields * catch date errors * change to programRegistrationAttributes * update programQuestions to programRegistrationAttribute * update 121 route * re-add fspName * update test * update * remove required field mitigation measure (not needed in 121 anymore) --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> Co-authored-by: Wessel de Jong <[email protected]>
tijsziere
added a commit
that referenced
this pull request
Feb 27, 2025
* merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions * Included not in payment export (#66) * Merge into prod (#65) * merge main into dev (#58) * merge dev into main - fix empty label in create 121 program (#53) * fix empty label bug * Add support for barcode question type (#54) * fix empty label bug * improve clarity * fix error * add support for kobo barcode questiontype --------- Co-authored-by: Jacopo Margutti <[email protected]> * exception: map fspName to programFinancialServiceProviderConfigurationName * exception for nlrc * Update test_koboto121.py Change fspName to programFinancialServiceProviderConfigurationName in test * Changed endpoint url path post registrations Signed-off-by: Ruben <[email protected]> * Update README.md * remove nlrc exceptions --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * Removed included from export * change test accordingly * also remove phoneNumber from payment export, fix tests * remove print --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: tijsziere <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> * better error handling * improve error handling, remove unnecessary checkfields * catch date errors * change to programRegistrationAttributes * update programQuestions to programRegistrationAttribute * update 121 route * re-add fspName * update test * update * remove required field mitigation measure (not needed in 121 anymore) * add create-validation-from route * drop questions with no pulldata functionality * add logging * add delayed start to update csv endpoint * Add docstring to create-offline-validation-form * change payload (#74) * change to all-registrations * change test payload --------- Signed-off-by: Ruben <[email protected]> Co-authored-by: Jacopo Margutti <[email protected]> Co-authored-by: Sanne Berendschot <[email protected]> Co-authored-by: Ruben <[email protected]> Co-authored-by: RubenGeo <[email protected]> Co-authored-by: Daan Gorsse <[email protected]> Co-authored-by: Wessel de Jong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge when 121 released to NLRC Prod instance