Fix typing #191
Merged
Fix typing #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous attempt to manually sync missed some details, then remove the outdated @types/socket-io and use the built-in types instead. Then do a mapping of the original IoSocket type to the wrapped, forcing the wrapper to be returned for chained, properties should alway match. This will force the wrapper to be in sync without much effort.
None of these fields should be reassigned once they are created, so they are all readonly. Except by ioSocket, all are of internal use, so keep them private.
off() without an event name just unregisters all event handlers via EventEmitter. The comment implied offAny() would do this, but it's not the case: that just removes the onAny() handlers. If we really wanted to remove all event handlers for everything we should be calling: - offAny() - offAnyOutgoing() - off() But that would not match the wrapped behavior, so let's just keep it simple.
|
ping :-) |
1 similar comment
|
ping :-) |
|
hi @rodgc , not sure if you're out or busy, let me know if I can help to get this merged :-) |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some fixes from #190, this time let's use
tscto force us to be in sync.