Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add viewport-unit mixin #66

Merged
merged 1 commit into from
Mar 10, 2016
Merged

add viewport-unit mixin #66

merged 1 commit into from
Mar 10, 2016

Conversation

drunkbream
Copy link

Hi Rodneyrehm, thanks for you work.
I'm using Buggyfill on binomo.com and don't want duplicate code in content property everytime, thus create this mixin.
I hope that you appreciate.


@mixin viewport-unit($prop-value){
$str:;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be $str: ""; instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sass developer says "Sass isn’t very strict with variable types"(http://hugogiraudel.com/2013/07/15/understanding-sass-lists/). Edit as you like.

@rodneyrehm
Copy link
Owner

nice! this alleviates the need for #32

rodneyrehm added a commit that referenced this pull request Mar 10, 2016
add viewport-unit mixin to examples
@rodneyrehm rodneyrehm merged commit ce080f0 into rodneyrehm:master Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants