Skip to content

Commit

Permalink
Signed bits and fixed a problem with ip2md when inherited token is th…
Browse files Browse the repository at this point in the history
…e same of the class token for a method
  • Loading branch information
rodneyviana committed Jun 2, 2021
1 parent 8c4ca94 commit a6c30cc
Show file tree
Hide file tree
Showing 25 changed files with 19 additions and 9 deletions.
File renamed without changes.
Binary file added Binaries/NetExt-2.1.63.5000.zip
Binary file not shown.
Binary file modified Binaries/README.md
Binary file not shown.
Binary file modified Binaries/x64/NetExt.dll
Binary file not shown.
Binary file modified Binaries/x64/NetExt.pdb
Binary file not shown.
Binary file modified Binaries/x64/NetExtShim.dll
Binary file not shown.
Binary file modified Binaries/x64/NetExtShim.pdb
Binary file not shown.
Binary file modified Binaries/x86/NetExt.dll
Binary file not shown.
Binary file modified Binaries/x86/NetExtShim.dll
Binary file not shown.
4 changes: 2 additions & 2 deletions ClrMemDiagExt/COMInterop.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3724,9 +3724,9 @@ public int MakeSourceInternal(ulong IP=0)
{

Module mod = IP == 0 ? DebugApi.ModuleFromScope : DebugApi.GetModuleFromIp(IP);
if (!mod.IsClr)
if (mod == null || !mod.IsClr)
{
Exports.WriteLine("Module {0} is not managed. No source will be created.", mod.Name);
Exports.WriteLine("Module {0} is not managed or could not be found. No source will be created.", mod.Name);
Exports.WriteLine("Move to the frame context in the stack where you want the code created (example .frame 3)");
return HRESULTS.E_FAIL;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,10 @@ public override ClrMethod GetMethodByHandle(ulong methodHandle)
ClrType type = Heap.GetTypeByMethodTable(methodDesc.MethodTable);
if (type == null)
return null;

#if DEBUG
var p = type.GetMethod(methodDesc.MDToken);
var name = p.Name;
#endif
return type.GetMethod(methodDesc.MDToken);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1416,7 +1416,7 @@ private void InitFields()

internal override ClrMethod GetMethod(uint token)
{
return Methods.Where(m => m.MetadataToken == token).FirstOrDefault();
return Methods.Where(m => m.MetadataToken == token).LastOrDefault();
}

public override IList<ClrMethod> Methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -463,9 +463,11 @@ internal static PdbFunction[] LoadFunctions(Stream read,
dir._streams[1].Read(reader, bits);
Dictionary<string, int> nameIndex = LoadNameIndex(bits, out ver, out sig, out age, out guid);
int nameStream;
List<PdbFunction> funcList = new List<PdbFunction>();
if (!nameIndex.TryGetValue("/NAMES", out nameStream))
{
throw new PdbException("No `name' stream");
return funcList.ToArray(); // It's a public symbol with no method information
//throw new PdbException("No `name' stream");
}

dir._streams[nameStream].Read(reader, bits);
Expand All @@ -474,7 +476,7 @@ internal static PdbFunction[] LoadFunctions(Stream read,
dir._streams[3].Read(reader, bits);
LoadDbiStream(bits, out modules, out header, readAllStrings);

List<PdbFunction> funcList = new List<PdbFunction>();

Dictionary<string, PdbSource> sourceDictionary = new Dictionary<string, PdbSource>();
if (modules != null)
{
Expand Down
4 changes: 2 additions & 2 deletions ClrMemDiagExt/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
// The following GUID is for the ID of the typelib if this project is exposed to COM
[assembly: Guid("f12c38b7-0893-4208-ab3d-54c3f8d1c01e")]

[assembly: AssemblyVersion("2.1.62.5000")]
[assembly: AssemblyFileVersion("2.1.62.5000")]
[assembly: AssemblyVersion("2.1.63.5000")]
[assembly: AssemblyFileVersion("2.1.63.5000")]
Binary file modified NetExt/Release32/CL.read.1.tlog
Binary file not shown.
Binary file modified NetExt/Release32/CL.write.1.tlog
Binary file not shown.
Binary file modified NetExt/Release32/NetExt.res
Binary file not shown.
5 changes: 5 additions & 0 deletions NetExt/Release32/NetExt.write.1.tlog
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,8 @@ C:\Users\rviana\OneDrive\Projects\netext\Release32\NetExt.lib
C:\Users\rviana\OneDrive\Projects\netext\Release32\NetExt.lib
C:\Users\rviana\OneDrive\Projects\netext\Release32\NetExt.exp
C:\Users\rviana\OneDrive\Projects\netext\Release32\NetExt.exp
^C:\Users\rviana\OneDrive\Projects\netext\NetExt\NetExt.vcxproj
C:\Users\rviana\OneDrive\Projects\netext\Release32\NetExt.lib
C:\Users\rviana\OneDrive\Projects\netext\Release32\NetExt.lib
C:\Users\rviana\OneDrive\Projects\netext\Release32\NetExt.exp
C:\Users\rviana\OneDrive\Projects\netext\Release32\NetExt.exp
Binary file modified NetExt/Release32/cl.command.1.tlog
Binary file not shown.
2 changes: 1 addition & 1 deletion NetExt/VersionInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#ifndef ver_major
#define ver_major 2
#define ver_minor 1
#define ver_release 62
#define ver_release 63
#define ver_build 5000
#define ver_all(a,b,c,d) a,b,c,d
#define ver_expand(s) #s
Expand Down
Binary file modified README.md
Binary file not shown.
Binary file modified Release32/NetExt.exp
Binary file not shown.
Binary file modified Release32/NetExt.lib
Binary file not shown.
Binary file modified x86/Release32/NetExt.dll
Binary file not shown.
Binary file modified x86/Release32/NetExtShim.dll
Binary file not shown.

0 comments on commit a6c30cc

Please sign in to comment.