List messages #11
Open
List messages #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzofab91
reviewed
Aug 30, 2021
DJA89
reviewed
Sep 3, 2021
| def index | ||
| @conversation = Conversation.find(params[:conversation_id]) | ||
| if @conversation && (current_user == @conversation.user1 || current_user == @conversation.user2) | ||
| @messages = @conversation.messages.limit(params[:limit]).offset(params[:offset]) |
There was a problem hiding this comment.
It would be good to choose an upper limit for limit, so a user can't just ask for a million messages, extreme and probably there won't be a conversation with that, but you can set a limit of 10 or 20 and they can make multiple requests if they want to.
enzofab91
approved these changes
Sep 3, 2021
|
|
||
| def max_items_page | ||
| limit = Integer(params[:limit]) | ||
| limit <= 20 ? limit : 20 |
There was a problem hiding this comment.
You can define a constant or an env variable.
| def max_items_page | ||
| limit = Integer(params[:limit]) | ||
| limit <= 20 ? limit : 20 | ||
| end |
There was a problem hiding this comment.
Optional: Maybe it's a good idea to use a gem like pagy to implement pagination.
DJA89
approved these changes
Sep 15, 2021
sebastiancaraballo
approved these changes
Sep 16, 2021
Comment on lines
+17
to
+18
| validates :user, presence: false | ||
| validates :conversation, presence: false |
There was a problem hiding this comment.
Is this necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/BfWJrarf/11-5-as-a-user-i-should-be-able-to-see-the-message-history-paginated-in-a-conversation