Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes #129

Merged
merged 22 commits into from
Feb 19, 2025
Merged

UI changes #129

merged 22 commits into from
Feb 19, 2025

Conversation

zhengc84
Copy link
Collaborator

@zhengc84 zhengc84 commented Feb 13, 2025

Updated UI format, implemented dynamic resizing for different resolutions, added btree scrollbar and implemented issue #134

@zhengc84 zhengc84 requested a review from mantkiew February 13, 2025 20:03
Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely, I'm getting this error:

Process Process-4:
Traceback (most recent call last):
  File "/home/ma/micromamba/envs/gss/lib/python3.11/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/home/ma/micromamba/envs/gss/lib/python3.11/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/ma/geoscenarioserver/dash/Dashboard.py", line 75, in run_dash_process
    self.tree_msg.configure(text= "")
  File "/home/ma/micromamba/envs/gss/lib/python3.11/tkinter/__init__.py", line 1721, in configure
    return self._configure('configure', cnf, kw)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ma/micromamba/envs/gss/lib/python3.11/tkinter/__init__.py", line 1711, in _configure
    self.tk.call(_flatten((self._w, cmd)) + self._options(cnf))
_tkinter.TclError: unknown option "-text"

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs without the error now. It's nice, I can use <super>+<left> to use half the screen and <super>+<up> to maximize.

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why is the text "Behavior tree. Vehicle 1" twice?

image

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue when running Ubuntu on Wayland with two monitors: the window spans the both screens. When using just normal Ubuntu on Xserver, it works normally.
image

I wonder if instead of getting the size of the screen (which includes both monitors!), we should simply open the window in a maximized state?

Please address the other comments too.

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting this now:

Process Process-4:
Traceback (most recent call last):
  File "/home/ma/micromamba/envs/gss/lib/python3.11/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/home/ma/micromamba/envs/gss/lib/python3.11/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/ma/geoscenarioserver/dash/Dashboard.py", line 66, in run_dash_process
    self.window = self.create_gui()
                  ^^^^^^^^^^^^^^^^^
  File "/home/ma/geoscenarioserver/dash/Dashboard.py", line 714, in create_gui
    window.configure("-fullscreen", True)
TypeError: Misc.configure() takes from 1 to 2 positional arguments but 3 were given

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traceback (most recent call last):
  File "/home/ma/micromamba/envs/gss/lib/python3.11/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/home/ma/micromamba/envs/gss/lib/python3.11/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/ma/geoscenarioserver/dash/Dashboard.py", line 66, in run_dash_process
    self.window = self.create_gui()
                  ^^^^^^^^^^^^^^^^^
  File "/home/ma/geoscenarioserver/dash/Dashboard.py", line 714, in create_gui
    window.configure("-fullscreen", True)
TypeError: Misc.configure() takes from 1 to 2 positional arguments but 3 were given

I wonder whether I have some other version of the library? Are you working within the gss conda env?

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this on MS surface, linux, Wayland
image
Is that normal?

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
That's on MS Surface, linux, X.

@mantkiew
Copy link
Collaborator

I think, we have to set some minimum size for the window and the plots. When I start GSS, it appears very small.
image
So, the setting -zoomed does not seem to work.

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the fonts are really horrible looking. I found this tip: https://stackoverflow.com/questions/6698421/tkinter-fonts-on-mac-os-x Maybe we can try.

Also, only SDV vehicles have the behavior tree. All other types don't have it at all, so probably nothing should be shown.

Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like you're reverting stuff that was already on master.

@zhengc84 zhengc84 changed the title UI changes UI changes: Updated UI format, added btree scrollbar and implemented issue #134 Feb 19, 2025
@zhengc84 zhengc84 changed the title UI changes: Updated UI format, added btree scrollbar and implemented issue #134 UI changes Feb 19, 2025
Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mantkiew mantkiew merged commit e4c8daf into master Feb 19, 2025
@mantkiew mantkiew deleted the UI-changes branch February 19, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants