Skip to content

Commit

Permalink
docs: add a second PR template, for software and other non-mapping PRs
Browse files Browse the repository at this point in the history
  • Loading branch information
joanise committed Apr 30, 2024
1 parent fc43dbd commit 6a5265a
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
Pull request template for adding a new language
-----------------------------------------------

*Do not use this for other types of pull requests*
<!--
- Use this template if you are adding a new language or modifying a mapping
- For all other PRs, please add ?expand=1&template=software_pr.md to the URL above
to use the software PR template instead.
-->

* **Please check if the PR fulfills these requirements**
- [ ] Mapping files are added in `g2p/mappings/langs`
Expand Down
36 changes: 36 additions & 0 deletions .github/pull_request_template/software_pr.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<!-- PR template: please provide enough information to guide your reviewers.
Please read Contributing.md before submitting a PR. -->

### PR Goal? <!-- Explain the main objective of this PR. -->



### Fixes? <!-- List any issues this PR fixes, e.g. Fixes #42, Fixes #324 -->



### Feedback sought? <!-- What should reviewers focus on in particular? -->



### Priority? <!-- How soon would you like this PR reviewed, does it block other work? -->



### Tests added? <!-- Make sure your PR includes automated tests for your changes. -->



### How to test? <!-- Explain how reviewers should test this PR. -->



### Confidence? <!-- How confident are you that these changes are ready to merge? -->



### Version change? <!-- Do you think this PR should trigger a Major (Breaking Change)/Minor (New Feature)/patch (refactor/bug fix) version change? -->



<!-- Add any other relevant information here -->

0 comments on commit 6a5265a

Please sign in to comment.