address warning from Heroku in build log #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should not have affected the build, yet the build failed. Testing whether it has to do with gunicorn just releasing its 21.1.0 version, or related dependencies. |
dnspython 2.4.0 drops requests support so we need <=2.3.0 See https://www.dnspython.org/news/2.4.0/
We previously locked to a specific gunicorn commit because of an incompatibility with recent eventlet versions. gunicorn now released a new version that includes this patch, so we can use it instead.
joanise
force-pushed
the
dev.bump-heroku-runtime
branch
from
8cb3a7b
to
a447a20
Compare
|
PR rebased on top of #273, which repairs the build, so we can test this PR itself specifically. |
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 16 16
Lines 2247 2247
Branches 534 534
=======================================
Hits 2054 2054
Misses 117 117
Partials 76 76 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roedoejet
approved these changes
Jul 18, 2023
|
You're on it! thanks for doing this so quickly Eric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by bumping the runtime to have the latest security patch