Add more types to network_lite

[dhdaines]

More types! More types!

[github-actions]

CLI load time: 0:00.05
Pull Request HEAD: cd61c425df891db3c671afe438e3b750fce10736
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (b5e2258) to head (1b5573f).

Additional details and impacted files

@@                   Coverage Diff                   @@
##           dev.ej/network-lite     #398      +/-   ##
=======================================================
+ Coverage                93.46%   93.50%   +0.03%     
=======================================================
  Files                       18       18              
  Lines                     2541     2554      +13     
  Branches                   576      576              
=======================================================
+ Hits                      2375     2388      +13     
  Misses                      95       95              
  Partials                    71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joanise]

Wow, that is some serious typing work! Thanks for doing this, I would not have known how to do it all.
Maybe add one more:

LANGS_NETWORK: DiGraph[str] = load_network()

in langs/__init__.py

[dhdaines]

One thing to note here: I'm using (with some difficulty) TypedDict to check the types for node_link_graph and node_link_data but this is actually not very useful because they deal with data that is loaded from JSON at runtime and thus always has type Any. So, in fact, we should use Pydantic here instead ;-)

I shouldn't take any more time away from my other important work (whatever it is) to do that today but I might do it later this week.

[dhdaines]

One thing to note here: I'm using (with some difficulty) TypedDict to check the types for node_link_graph and node_link_data but this is actually not very useful because they deal with data that is loaded from JSON at runtime and thus always has type Any.

Run-time validation is really a separate issue here (and not strictly necessary given that we know where the data comes from) so I'll leave it for the future.

[joanise]

This is awesome, thank you!