-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more types to network_lite #398
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev.ej/network-lite #398 +/- ##
=======================================================
+ Coverage 93.46% 93.50% +0.03%
=======================================================
Files 18 18
Lines 2541 2554 +13
Branches 576 576
=======================================================
+ Hits 2375 2388 +13
Misses 95 95
Partials 71 71 ☔ View full report in Codecov by Sentry. |
1b7f0e5
to
5cfda57
Compare
Wow, that is some serious typing work! Thanks for doing this, I would not have known how to do it all.
in |
One thing to note here: I'm using (with some difficulty) I shouldn't take any more time away from my other important work (whatever it is) to do that today but I might do it later this week. |
Run-time validation is really a separate issue here (and not strictly necessary given that we know where the data comes from) so I'll leave it for the future. |
This commit combines the followed commits, all by dhd: - feat: add full type signatures to DiGraph - fix: support python 3.7 - fix: one more type annotation Theres always one more type annotation! - fix: one more type annotation (again!) Theres always one more type annotation! - fix: nope! it does not just work - fix: one more type annotation Theres always one more type annotation!
1b5573f
to
cd61c42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you!
More types! More types!