feat(migrations): add support for migrations (closes #38)

rogerpadilla · Aug 17, 2021 · 9d239ac · 9d239ac
1 parent b3ddb2b
commit 9d239ac
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 5 deletions.
diff --git a/packages/core/src/querier/abstractSqlQuerier-it.ts b/packages/core/src/querier/abstractSqlQuerier-it.ts
@@ -4,7 +4,7 @@ import { AbstractQuerierIt } from './abstractQuerier-it';
 import { AbstractSqlQuerier } from './abstractSqlQuerier';
 
 export abstract class AbstractSqlQuerierIt extends AbstractQuerierIt<AbstractSqlQuerier> {
-  readonly idType: string = 'INTEGER PRIMARY KEY';
+  readonly idType: string = 'SERIAL PRIMARY KEY';
 
   constructor(pool: QuerierPool<AbstractSqlQuerier>) {
     super(pool);

diff --git a/packages/core/src/querier/abstractSqlQuerier-spec.ts b/packages/core/src/querier/abstractSqlQuerier-spec.ts
@@ -4,7 +4,8 @@ import { QuerierPool } from '@uql/core/type';
 import { AbstractSqlQuerier } from './abstractSqlQuerier';
 
 export abstract class AbstractSqlQuerierSpec implements Spec {
-  readonly idType: string = 'INTEGER PRIMARY KEY';
+  readonly idType: string = 'SERIAL PRIMARY KEY';
+
   querier: AbstractSqlQuerier;
 
   constructor(readonly pool: QuerierPool<AbstractSqlQuerier>) {}

diff --git a/packages/core/src/querier/abstractSqlQuerier.ts b/packages/core/src/querier/abstractSqlQuerier.ts
@@ -151,7 +151,8 @@ export abstract class AbstractSqlQuerier extends AbstractQuerier {
   }
 
   override async changeColumn(table: string, column: string, options?: Column) {
-    await this.run(``);
+    const sqlOptions = this.columnOptionsToSql(options);
+    await this.run(`ALTER TABLE ${this.escapeId(table)} CHANGE COLUMN ${this.escapeId(column)}${sqlOptions}`);
   }
 
   override async renameColumn(table: string, oldColumn: string, newColumn: string) {
@@ -160,6 +161,9 @@ export abstract class AbstractSqlQuerier extends AbstractQuerier {
 
   columnOptionsToSql(opts: Column) {
     let sql = '';
+    if (opts.type) {
+      sql += ` ${opts.type.toUpperCase()}`;
+    }
     if (opts.required) {
       sql += ' NOT NULL';
     }
@@ -172,7 +176,7 @@ export abstract class AbstractSqlQuerier extends AbstractQuerier {
     if (opts.unique) {
       sql += ' UNIQUE';
     }
-    if (opts.primary) {
+    if (opts.id) {
       sql += ' PRIMARY KEY';
     }
     if (opts.comment) {

diff --git a/packages/core/src/type/querier.ts b/packages/core/src/type/querier.ts
@@ -192,7 +192,7 @@ export type Column = {
   /**
    * Primary key flag
    */
-  primary?: boolean;
+  id?: boolean;
   required?: boolean;
   default?: string;
   comment?: string;

diff --git a/packages/sqlite/src/sqlite3Querier.it.ts b/packages/sqlite/src/sqlite3Querier.it.ts
@@ -3,9 +3,18 @@ import { AbstractSqlQuerierIt } from '@uql/core/querier/abstractSqlQuerier-it';
 import { Sqlite3QuerierPool } from './sqlite3QuerierPool';
 
 export class Sqlite3QuerierIt extends AbstractSqlQuerierIt {
+  readonly idType = 'INTEGER PRIMARY KEY';
+
   constructor() {
     super(new Sqlite3QuerierPool({ filename: ':memory:' }));
   }
+
+  async beforeAll() {
+    await super.beforeAll();
+    this.querier = await this.pool.getQuerier();
+    await this.querier.run('PRAGMA foreign_keys = ON');
+    await this.querier.release();
+  }
 }
 
 createSpec(new Sqlite3QuerierIt());
diff --git a/packages/sqlite/src/sqliteQuerier.spec.ts b/packages/sqlite/src/sqliteQuerier.spec.ts
@@ -3,9 +3,18 @@ import { createSpec } from '@uql/core/test';
 import { Sqlite3QuerierPool } from './sqlite3QuerierPool';
 
 class SqliteQuerierSpec extends AbstractSqlQuerierSpec {
+  readonly idType = 'INTEGER PRIMARY KEY';
+
   constructor() {
     super(new Sqlite3QuerierPool({ filename: ':memory:' }));
   }
+
+  async beforeAll() {
+    await super.beforeAll();
+    this.querier = await this.pool.getQuerier();
+    await this.querier.run('PRAGMA foreign_keys = ON');
+    await this.querier.release();
+  }
 }
 
 createSpec(new SqliteQuerierSpec());