-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created ARIMA model #100
Created ARIMA model #100
Conversation
stages of training arima : - intially just on date and close - combining with lstm - updating data to include days , lags and other features and include while training Current RMSE : 4.67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the PR matches the requirements mentioned in the Contribution guide. The maintainer might get in touch to enusre quality. Thanks for your time
As time series analysis was time consuming , I would appreciate if you would label it as level3 |
@rohitinu6 , please let me know if any further changes are needed. Otherwise, I would appreciate it if you could merge the PR. |
@DarshAgrawal14 Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here: Thanks & regards. |
@Mayureshd-18 I added the 'closes' keyword along with issue number .if anything else , let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@rohitinu6 ,The pull request was submitted 4 days ago and received approval from @Mayureshd-18 day before yesterday. Could you kindly provide an update on the cause of the delay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
can you add the Labels |
Just add the appropriate level label and then I can merge it |
@Mayureshd-18 ,the label given in the issue is 2 but I asking for level 3 because, doing time series analysis was time consuming .The major part of the project was that i added additional features such as moving averages which i found by learning stock prediction and dividing dates into peices in order to notice the days which is important for both share prices estimation and time series analysis . general time series analysis include taking dataset , creating model with best p , d , q order and other deep learning steps. but the steps i mentioned is what that makes the model better |
Created ARIMA model
Fixed issue : #41
Closes #41
stages of training arima :
Current RMSE : 4.67
i couldnt upload the model and scaler files due to space constraints but by running ARIMA_V2.py , the respective files will be created automatically
Darsh Agrawal GSSoC 24 extd contributor