Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created ARIMA model #100

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Created ARIMA model #100

merged 2 commits into from
Oct 13, 2024

Conversation

DarshAgrawal14
Copy link
Contributor

@DarshAgrawal14 DarshAgrawal14 commented Oct 8, 2024

Fixed issue : #41

Closes #41

stages of training arima :

  • intially just on Dates and Close prices
  • combining with LSTM
  • updating data to include days , lags and other features and include while training

Current RMSE : 4.67

i couldnt upload the model and scaler files due to space constraints but by running ARIMA_V2.py , the respective files will be created automatically

Darsh Agrawal GSSoC 24 extd contributor

stages of training arima :
- intially just on date and close
- combining with lstm
- updating data to include days , lags and other features and include while training

Current RMSE : 4.67
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the PR matches the requirements mentioned in the Contribution guide. The maintainer might get in touch to enusre quality. Thanks for your time

@DarshAgrawal14
Copy link
Contributor Author

DarshAgrawal14 commented Oct 8, 2024

As time series analysis was time consuming , I would appreciate if you would label it as level3

@DarshAgrawal14
Copy link
Contributor Author

@rohitinu6 , please let me know if any further changes are needed. Otherwise, I would appreciate it if you could merge the PR.

@Mayureshd-18
Copy link
Collaborator

@DarshAgrawal14 Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Thanks & regards.

@DarshAgrawal14
Copy link
Contributor Author

DarshAgrawal14 commented Oct 11, 2024

@Mayureshd-18 I added the 'closes' keyword along with issue number .if anything else , let me know.

Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@DarshAgrawal14
Copy link
Contributor Author

@rohitinu6 ,The pull request was submitted 4 days ago and received approval from @Mayureshd-18 day before yesterday. Could you kindly provide an update on the cause of the delay?

@Mayureshd-18 Mayureshd-18 self-requested a review October 13, 2024 06:37
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@DarshAgrawal14
Copy link
Contributor Author

can you add the Labels
gssoc-ext , hacktoberfest-accepted and level label to the PR please.

@Mayureshd-18 Mayureshd-18 added gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 hacktoberfest Hacktober Collaboration labels Oct 13, 2024
@Mayureshd-18
Copy link
Collaborator

Just add the appropriate level label and then I can merge it

@DarshAgrawal14
Copy link
Contributor Author

DarshAgrawal14 commented Oct 13, 2024

@Mayureshd-18 ,the label given in the issue is 2 but I asking for level 3 because, doing time series analysis was time consuming .The major part of the project was that i added additional features such as moving averages which i found by learning stock prediction and dividing dates into peices in order to notice the days which is important for both share prices estimation and time series analysis . general time series analysis include taking dataset , creating model with best p , d , q order and other deep learning steps. but the steps i mentioned is what that makes the model better

@Mayureshd-18 Mayureshd-18 added the level2 25 Points 🥈 label Oct 13, 2024
@Mayureshd-18 Mayureshd-18 self-requested a review October 13, 2024 17:29
@Mayureshd-18 Mayureshd-18 added level3 45 Points 🥉 and removed level2 25 Points 🥈 labels Oct 13, 2024
@Mayureshd-18 Mayureshd-18 merged commit 28e9d5b into rohitinu6:main Oct 13, 2024
2 of 3 checks passed
shristirwt pushed a commit to shristirwt/Stock-Price-Prediction that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 level3 45 Points 🥉
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Train ARIMA (Autoregressive Integrated Moving Average) for stock predition
3 participants