Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Eda to Market Trend Classification Model #206

Closed
wants to merge 1 commit into from
Closed

Added Eda to Market Trend Classification Model #206

wants to merge 1 commit into from

Conversation

SimranShaikh20
Copy link
Contributor

@SimranShaikh20 SimranShaikh20 commented Oct 31, 2024 •
edited by Mayureshd-18
Loading

fixes - #202
Issue no - #202
Closes #202

I have added eda to market trend classification !

@rohitinu6 pls review it and if there is any conflicts let me know !

@github-actions GitHub Actions
Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Mayureshd-18 Mayureshd-18 self-requested a review October 31, 2024 12:03
Mayureshd-18
Mayureshd-18 requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimranShaikh20 Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

If needed, please check out merged PRs for reference.

Thanks & regards

@SimranShaikh20
Copy link
Contributor Author

SimranShaikh20 commented Oct 31, 2024 •
edited
Loading

@Mayureshd-18 i have added fixes and close tag
Can you pls check and let me know any other changes i have made !

@SimranShaikh20
Copy link
Contributor Author

@rohitinu6 pls check PR and merged it !

@SimranShaikh20
Copy link
Contributor Author

SimranShaikh20 commented Nov 3, 2024 •
edited
Loading

@rohitinu6 can you pls merged this pr!

@SimranShaikh20
Copy link
Contributor Author

@jvedsaqib pls check PR and merged it .
If there is any conflicts then let me know!

@Mayureshd-18 Mayureshd-18 self-requested a review November 4, 2024 20:30
Mayureshd-18
Mayureshd-18 requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimranShaikh20 Please use the correct keywords to link the issue. It should be visible on PRs page. Please refer to other merged PRs for reference.

Thanks and regards

@Mayureshd-18
Copy link
Collaborator

@jvedsaqib Checked the code. Lgtm. See on your side pls.

SimranShaikh20
SimranShaikh20 commented Nov 5, 2024
View reviewed changes
Copy link
Contributor Author

@SimranShaikh20 SimranShaikh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commited

@SimranShaikh20
Copy link
Contributor Author

SimranShaikh20 commented Nov 5, 2024 •
edited
Loading

@jvedsaqib Checked the code. Lgtm. See on your side pls.

@Mayureshd-18
yes pls check i have added

@Mayureshd-18 Mayureshd-18 self-requested a review November 5, 2024 05:42
Mayureshd-18
Mayureshd-18 requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimranShaikh20 As you can see that even after your changes this PR is not linked to the issue correctly as the issue cant be seen on the Prs page directy,
How about you try to add just Closes <issueno.> in the description directly?

Thanks

@SimranShaikh20
Copy link
Contributor Author

SimranShaikh20 commented Nov 5, 2024 •
edited
Loading

@SimranShaikh20 As you can see that even after your changes this PR is not linked to the issue correctly as the issue cant be seen on the Prs page directy, How about you try to add just Closes <issueno.> in the description directly?

Thanks

Apologize for inconvenience I had make changes pls check and merged it

@Mayureshd-18
Copy link
Collaborator

@SimranShaikh20 As you can see that even after your changes this PR is not linked to the issue correctly as the issue cant be seen on the Prs page directy, How about you try to add just Closes <issueno.> in the description directly?
Thanks

Apologize for inconvenience I had make changes pls check and merged it

@SimranShaikh20 I edited your description. Now as you can see the issue is linked with the PR correctly. Adding the "-" will changed the format (refer to docs) and the issue was not linked correctly. Keep that in mind and hope you got it!

Thanks

@Mayureshd-18 Mayureshd-18 self-requested a review November 5, 2024 10:25
Mayureshd-18
Mayureshd-18 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mayureshd-18 Mayureshd-18 added the level2 25 Points 🥈 label Nov 5, 2024
@Mayureshd-18
Copy link
Collaborator

Will merge immediately after atleast one more review!

Thanks & regards

@SimranShaikh20
Copy link
Contributor Author

Will merge immediately after atleast one more review!

Thanks & regards

Okay

@SimranShaikh20
Copy link
Contributor Author

Looks good to me!

Pls add other label like gssoc ext

@SimranShaikh20
Copy link
Contributor Author

@rohitinu6 pls review to PR and is there any conflicts let me know

@Mayureshd-18 Mayureshd-18 added gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 hacktoberfest Hacktober Collaboration labels Nov 7, 2024
rohitinu6
rohitinu6 requested changes Nov 9, 2024
View reviewed changes
Copy link
Owner

@rohitinu6 rohitinu6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync your fork with the latest changes:
image

@SimranShaikh20
Copy link
Contributor Author

@rohitinu6 apolozies for inconvience update branch and synced repo
Kindly review my PR and merged it !

@rohitinu6
Copy link
Owner

@SimranShaikh20 it's not done yet

@SimranShaikh20
Copy link
Contributor Author

@rohitinu6 i will make new PR may there is some technical issue from my side

@SimranShaikh20 SimranShaikh20 mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitinu6 rohitinu6 rohitinu6 requested changes

@Mayureshd-18 Mayureshd-18 Mayureshd-18 approved these changes

@jvedsaqib jvedsaqib Awaiting requested review from jvedsaqib

Assignees

@SimranShaikh20 SimranShaikh20

Labels
gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 level2 25 Points 🥈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] <Adding Eda to Market Trend Classification Model>
3 participants
@SimranShaikh20 @Mayureshd-18 @rohitinu6