enabling test for scenario that was fixed earlier (dotnet#34975)

roji · Oct 25, 2024 · 2e9e879 · 2e9e879
1 parent 931a67c
commit 2e9e879
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/test/EFCore.Specification.Tests/Query/NorthwindWhereQueryTestBase.cs b/test/EFCore.Specification.Tests/Query/NorthwindWhereQueryTestBase.cs
@@ -1770,7 +1770,6 @@ public virtual Task Like_with_non_string_column_using_double_cast(bool async)
             ss => ss.Set<Order>().Where(o => EF.Functions.Like((string)(object)o.OrderID, "%20%")),
             ss => ss.Set<Order>().Where(o => o.OrderID.ToString().Contains("20")));
 
-    // see issue #31917
     [ConditionalTheory]
     [MemberData(nameof(IsAsyncData))]
     public virtual Task Using_same_parameter_twice_in_query_generates_one_sql_parameter(bool async)

diff --git a/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindWhereQuerySqlServerTest.cs b/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindWhereQuerySqlServerTest.cs
@@ -2125,18 +2125,18 @@ WHERE CAST([o].[OrderID] AS nvarchar(max)) LIKE N'%20%'
 """);
     }
 
-    [ConditionalTheory(Skip = "issue #31917")]
+    [ConditionalTheory]
     public override async Task Using_same_parameter_twice_in_query_generates_one_sql_parameter(bool async)
     {
         await base.Using_same_parameter_twice_in_query_generates_one_sql_parameter(async);
 
         AssertSql(
-            """
+"""
 @__i_0='10'
 
 SELECT [c].[CustomerID]
 FROM [Customers] AS [c]
-WHERE CAST(@__i_0 AS nchar(5)) + [c].[CustomerID] + CAST(@__i_0 AS nchar(5)) = N'10ALFKI10'
+WHERE CAST(@__i_0 AS nvarchar(max)) + [c].[CustomerID] + CAST(@__i_0 AS nvarchar(max)) = N'10ALFKI10'
 """);
     }