Add QDir support to rbx_types, rbx_xml, and reflection #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
reviewed
Jul 18, 2023
Comment on lines
+20
to
+22
| pub fn path_buf(&'a self) -> &'a PathBuf { | ||
| &self.path_buf | ||
| } |
There was a problem hiding this comment.
It feels more reasonable to return a &Path here rather than &PathBuf.
There was a problem hiding this comment.
This method is intended to be an accessor to the path_buf field (you can already get an &Path via the AsRef<Path> implementation). Thinking about it more, maybe this field doesn't really need an accessor?
There was a problem hiding this comment.
I'm not sure what the use is for a field accessor here. Maybe writing, though I don't believe this is how people generally do field mutability in Rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
QDirto rbx_types (a simple wrapper aroundPathBuf),QDir(de)serialization to rbx_xml, and also allows rbx_reflector to reflectQDirtype properties. It's geared towards the requirements of Kampfkarren/roblox-install#33, but is generally useful when interacting with Roblox Studio settings.