Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to the Docs that Unknown Instances will be automatically destroyed #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jackprogramsjp
Copy link

Rojo clears any unknown instances in a location it syncs to by default.

You'll need to add $ignoreUnknownInstances to either the project file or a .meta.json for the location you're syncing to.

To some people, they may not know this when they start Rojo, because you cannot assume that they are going through every single part of the docs, as they are wanting to get started right away, so they may skip some essential steps. Basically, they risk losing data if they are not acknowledged about this property.

This happened to me, and I lost data because I put Instances in, assuming Rojo wouldn't delete them, but it did since they were unknown.

Not everyone, again, is going to read the whole docs, so just when they install it, it should be a reminder therefore they don't make the same mistakes I did. When someone installs Rojo, they will definitely go through the Getting Started part of the docs, but not in the Sync Details docs if they have no interest.

Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels more suited for Porting an Existing Game over Creating a New Game.

Or, alternatively, on the sync details page. Either way, what was the motivation for putting it where you did?

@jackprogramsjp
Copy link
Author

jackprogramsjp commented Aug 3, 2023

Porting an Existing Game also works.

My motivation was that people might still feel ok to put unknown Instances in those specific areas when they create a new game, so they wouldn't know. It's just when people visit the site, Creating a New Game is something they would go first and check out, compared to other parts of the site, so it would be ok to tell them to make sure they know before creating a new game. Porting an Existing Game works, it's just that people who create new games may still not know about this unknown instance thingy.

I'm not sure about changing the default of the Unknown instance flag would solve everything, as some people might expect Rojo to not delete anything. It may be annoying to some people who want the Unknown instance flag to not destroy, but they can always set it up, and it's safer that way than actually defaulting it to destroying.

@Dekkonot
Copy link
Member

Dekkonot commented Aug 4, 2023

There's a limit to how much we can document things. If someone is going to Creating a New Game but not the rest of the documentation, is that really our fault?

I'd say we should put a warning like this in sync details but given how often people go into the OSS server and ask, I don't know if the people who need it would read that page...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants