Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow multiple rojo serve on the same port #211

Closed
Kampfkarren opened this issue Jul 4, 2019 · 3 comments
Closed

Don't allow multiple rojo serve on the same port #211

Kampfkarren opened this issue Jul 4, 2019 · 3 comments
Labels
scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen

Comments

@Kampfkarren
Copy link
Member

Regularly I'll have multiple rojo serve open without even realizing it. Would be nice for Rojo to abort if there's something else on that port.
@LPGhatguy LPGhatguy added scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen labels Jul 6, 2019
@LPGhatguy
Copy link
Contributor

Hm, I thought I fixed this with the move to a different HTTP server (see #65), but it looks like I didn't, oof. 🙁

@Kampfkarren Kampfkarren mentioned this issue Jan 7, 2020
Closed
@LPGhatguy
Copy link
Contributor

Seems like this is a known issue with Hyper, see this issue with Rocket.

In the current 0.6.0 alpha, Rojo's main thread panics, but then deadlocks when trying to join our Notify message converter thread. There's a comment in the code about this scenario, but I'm unsure how to fix it.

@LPGhatguy
Copy link
Contributor

It looks like on current master at least, Rojo no longer has this bug!

Instead, we get a crash, which is... better than nothing, but stops issues from running into this at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LPGhatguy @Kampfkarren