-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize old templates #746
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's actually probably fine to leave the template as model
instead of library
. It's the goto alternative to place
, so it makes sense to me.
This reverts commit bde1550.
Should we update the place to match the new Baseplate of Studio? |
It's a matter of preference but the current template we have has outdated Lighting properties. I think we should update it. Does anyone have any reservations about updating it? |
This PR is meant to start a discussion on improvements we can make to the old templates. If anyone disagrees with a change I made, let me know!
Here are the changes I made:
.gitignore
updates:rojo fmt-project
doesn't add a newline).README
s now recommend the binary format instead of XML.rojo fmt-project
on the place project file. I'm not sold on this, the output is a little strange androjo fmt-project
isn't even deterministic.FilteringEnabled
property from the place project file since it's always on by default now.I renamed themodel
template tolibrary
to better reflect what it does.