Skip sourcemap generation when unaffected by changes in watch mode #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
reviewed
Oct 12, 2023
Co-authored-by: Micah <[email protected]>
Dekkonot
approved these changes
Oct 13, 2023
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a mechanism for avoiding unnecessary sourcemap re-creation in
rojo sourcemap --watch.Consumers of
rojo sourcemap --watchwill no longer see new sourcemaps when changes to script sources and other properties occur, or when instances that have been ignored are changed, neither of which would actually make for changes in the sourcemap JSON body itself.This massively benefits tools such as luau-lsp and rojo-viewer that would previously need to parse sourcemaps every time the user makes changes to the contents of a script or other source file, which tend to be the most common operations.
The approach taken here is intentionally conservative - we could reasonably track refs and be even more granular, but I feel like that is out of scope for this initial PR and could lead to hard-to-find bugs if we're not careful. It is something that may be worth exploring in the future, though.