Normalize line endings to LF in Lua middleware #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... is this breaking? :( User code could theoretically be matching against only CRLF line endings currently (I'm mostly thinking about text files/StringValues - this is moot for scripts since Roblox now aggressively normalizes scripts to LF). I guess such code is busted regardless... |
Dekkonot
reviewed
Feb 8, 2024
kennethloeffler
changed the title
Dekkonot
approved these changes
Feb 12, 2024
kennethloeffler
deleted the
normalize-line-endings-in-textual-middlewares
branch
Dekkonot
pushed a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #776 by implementing a new method
Vfs::read_to_string_lf_normalizedand changing the Lua middleware to use it.I'm not really sure why the middlewares were calling
to_ownedoncontents_str- could it have been a limitation of earlier rbx-dom versions?