-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use msgpack for API #908
base: master
Are you sure you want to change the base?
Use msgpack for API #908
Conversation
I'm not sure what's the best way to go about fixing this. Ideally we also account for it types that have multiple numbers like |
I just pushed a commit to account for |
src/snapshot/patch_compute.rs
Outdated
@@ -224,6 +227,128 @@ fn compute_children_patches( | |||
} | |||
} | |||
|
|||
/// Trait where NaN values must not be treated as different. | |||
trait Different { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole trait is... not ideal. I would strongly prefer we move the equality check for Variant
to its own file, and make it a simple function instead of a trait.
I have a function already implemented in my syncback fork here if you want to steal it.
It does require us to pull in float_cmp
as a crate, but I think that's fine.
I'm now using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has the added Different
trait despite it not being used for anything anymore. It should be removed.
That's my bad, I thought I removed it. |
Fixes #363.
Fixes #881.
Remaining Tasks
msgpack
forwrite
api request.NaN
inside of patch compute.