Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support $schema in JSON structures #974

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Support $schema in JSON structures #974

merged 2 commits into from
Oct 24, 2024

Conversation

Dekkonot
Copy link
Member

@Dekkonot Dekkonot commented Oct 8, 2024

Closes #972.

This is a trivial change: we just add an unused $schema field to all of the JSON structs.

@Dekkonot Dekkonot added type: enhancement Feature or improvement that should potentially happen scope: cli Relevant to the Rojo CLI labels Oct 8, 2024
kennethloeffler
kennethloeffler approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@kennethloeffler kennethloeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and I can't detect any problems, lgtm

@Dekkonot Dekkonot merged commit d9ab0e7 into rojo-rbx:master Oct 24, 2024
6 checks passed
@Dekkonot Dekkonot deleted the schema-support branch October 24, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennethloeffler kennethloeffler kennethloeffler approved these changes

Assignees
No one assigned
Labels
scope: cli Relevant to the Rojo CLI type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support $schema field in *.project.json files
2 participants
@Dekkonot @kennethloeffler