array and assocarray interace type are case insensitive (#129)

Co-authored-by: Bronley Plumb <[email protected]>
rokucommunity · Aug 23, 2024 · 992c644 · 992c644
1 parent 05626c6
commit 992c644
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/plugins/codeStyle/index.spec.ts b/src/plugins/codeStyle/index.spec.ts
@@ -546,7 +546,8 @@ describe('codeStyle', () => {
         } as any);
         const actual = fmtDiagnostics(diagnostics);
         const expected = [
-            `06:LINT3024:Avoid using field type 'assocarray'`
+            `06:LINT3024:Avoid using field type 'assocarray'`,
+            `07:LINT3024:Avoid using field type 'assocarray'`
         ];
         expect(actual).deep.equal(expected);
     });
@@ -561,7 +562,8 @@ describe('codeStyle', () => {
         } as any);
         const actual = fmtDiagnostics(diagnostics);
         const expected = [
-            `04:LINT3025:Avoid using field type 'array'`
+            `04:LINT3025:Avoid using field type 'array'`,
+            `08:LINT3025:Avoid using field type 'array'`
         ];
         expect(actual).deep.equal(expected);
     });

diff --git a/src/plugins/codeStyle/index.ts b/src/plugins/codeStyle/index.ts
@@ -57,7 +57,7 @@ export default class CodeStyle {
             if (tag.text === 'field') {
                 const typeAttribute = attributes.find(({ key }) => key.text === 'type');
 
-                const typeValue = typeAttribute?.value.text;
+                const typeValue = typeAttribute?.value.text?.toLowerCase();
                 if (typeValue === 'array' && validateArrayComponentFieldType) {
                     diagnostics.push(
                         messages.noArrayFieldType(

diff --git a/test/project1/components/interfaceTest.xml b/test/project1/components/interfaceTest.xml
@@ -4,5 +4,7 @@
         <field id="test" type="array" />
         <field id="test2" type="node" />
         <field id="test3" type="assocarray" />
+        <field id="test3" type="assocArray" />
+        <field id="test" type="arRay" />
     </interface>
 </component>