fixed an issue with 577 error codes

rokucommunity · Jan 21, 2025 · 52ec5a1 · 52ec5a1
1 parent 608729e
commit 52ec5a1
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/src/RokuDeploy.spec.ts b/src/RokuDeploy.spec.ts
@@ -1208,13 +1208,38 @@ describe('index', () => {
             assert.fail('Should not have succeeded');
         });
 
-        it('Should throw an excpetion', async () => {
+        it('Should throw an exception and call doPost once', async () => {
+            options.failOnCompileError = true;
+            let spy = mockDoPostRequest('', 577);
+
+            try {
+                await rokuDeploy.publish(options);
+            } catch (e) {
+                expect(spy.callCount).to.eql(1);
+                assert.ok('Exception was thrown as expected');
+                expect(e).to.be.instanceof(errors.UpdateCheckRequiredError);
+                return;
+            }
+            assert.fail('Should not have succeeded');
+        });
+
+        it('Should throw an exception and should call doPost twice', async () => {
             options.failOnCompileError = true;
-            mockDoPostRequest('', 577);
+            let spy = sinon.stub(rokuDeploy as any, 'doPostRequest').callsFake((params: any) => {
+                let results: any;
+                if (params?.formData['mysubmit'] === 'Replace') {
+                    results = { response: { statusCode: 500 }, body: `'not an update error'` };
+                } else {
+                    results = { response: { statusCode: 577 }, body: `` };
+                }
+                rokuDeploy['checkRequest'](results);
+                return Promise.resolve(results);
+            });
 
             try {
                 await rokuDeploy.publish(options);
             } catch (e) {
+                expect(spy.callCount).to.eql(2);
                 assert.ok('Exception was thrown as expected');
                 expect(e).to.be.instanceof(errors.UpdateCheckRequiredError);
                 return;

diff --git a/src/RokuDeploy.ts b/src/RokuDeploy.ts
@@ -468,6 +468,8 @@ export class RokuDeploy {
                     //fail if this is a compile error
                     if (this.isCompileError(replaceError.message) && options.failOnCompileError) {
                         throw new errors.CompileError('Compile error', replaceError, replaceError.results);
+                    } else if (replaceError?.results?.response?.statusCode === 577 || (typeof replaceError?.results?.body === 'string' && this.isUpdateCheckRequiredResponse(replaceError.results.body))) {
+                        throw replaceError;
                     } else {
                         requestOptions.formData.mysubmit = 'Install';
                         response = await this.doPostRequest(requestOptions);