Add support for focusing a node in SceneGraph Inspector (#563)

Co-authored-by: Brian Leighty <[email protected]>
rokucommunity · Apr 17, 2024 · 551b821 · 551b821
1 parent f3270ef
commit 551b821
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/webviews/src/ExtensionIntermediary.ts b/webviews/src/ExtensionIntermediary.ts
@@ -4,7 +4,7 @@ import { RequestType } from 'roku-test-automation/client/dist/types/OnDeviceComp
 import type { VscodeCommand } from '../../src/commands/VscodeCommand';
 import type { ViewProviderEvent } from '../../src/viewProviders/ViewProviderEvent';
 import { ViewProviderCommand } from '../../src/viewProviders/ViewProviderCommand';
-import type { DeleteEntireRegistrySectionsArgs, DeleteNodeReferencesArgs, DeleteRegistrySectionsArgs, FindNodesAtLocationArgs, GetFocusedNodeArgs, GetNodesInfoArgs, GetNodesWithPropertiesArgs, GetValueArgs, GetValuesArgs, HasFocusArgs, IsInFocusChainArgs, OnFieldChangeOnceArgs, ReadRegistryArgs, RequestOptions, SetValueArgs, StoreNodeReferencesArgs, WriteRegistryArgs, GetVolumeListArgs, GetDirectoryListingArgs, StatPathArgs, RenameFileArgs, DeleteFileArgs, CreateDirectoryArgs, RemoveNodeChildrenArgs } from 'roku-test-automation';
+import type { DeleteEntireRegistrySectionsArgs, DeleteNodeReferencesArgs, DeleteRegistrySectionsArgs, FindNodesAtLocationArgs, GetFocusedNodeArgs, GetNodesInfoArgs, GetNodesWithPropertiesArgs, GetValueArgs, GetValuesArgs, HasFocusArgs, IsInFocusChainArgs, OnFieldChangeOnceArgs, ReadRegistryArgs, RequestOptions, SetValueArgs, StoreNodeReferencesArgs, WriteRegistryArgs, GetVolumeListArgs, GetDirectoryListingArgs, StatPathArgs, RenameFileArgs, DeleteFileArgs, CreateDirectoryArgs, RemoveNodeChildrenArgs, FocusNodeArgs } from 'roku-test-automation';
 
 class ExtensionIntermediary {
     private inflightRequests = {};
@@ -248,6 +248,10 @@ class ODCIntermediary {
     public async removeNodeChildren(args: RemoveNodeChildrenArgs, options?: RequestOptions) {
         return this.sendOdcMessage<ReturnType<typeof rta.odc.removeNodeChildren>>(RequestType.removeNodeChildren, args, options);
     }
+
+    public async focusNode(args: FocusNodeArgs, options?: RequestOptions) {
+        return this.sendOdcMessage<ReturnType<typeof rta.odc.focusNode>>(RequestType.focusNode, args, options);
+    }
 }
 
 type ObserverCallback = (message) => void;

diff --git a/webviews/src/views/SceneGraphInspectorView/Branch.svelte b/webviews/src/views/SceneGraphInspectorView/Branch.svelte
@@ -3,7 +3,7 @@
     import throttle from 'just-throttle';
     import { odc } from '../../ExtensionIntermediary';
     import { utils } from '../../utils';
-    import { Eye, EyeClosed, DebugBreakpointDataUnverified, Move } from 'svelte-codicons';
+    import { Eye, EyeClosed, DebugBreakpointDataUnverified, Move, Issues } from 'svelte-codicons';
     import Chevron from '../../shared/Chevron.svelte';
     import type { TreeNodeWithBase } from '../../shared/types';
     import { createEventDispatcher } from 'svelte';
@@ -171,6 +171,12 @@
         expanded = true;
         dispatch('childExpanded');
     }
+
+    async function focusNode() {
+        await odc.focusNode({
+            keyPath: treeNode.keyPath
+        });
+    }
 </script>
 
 <style>
@@ -265,6 +271,12 @@
         </span>
     </div>
     <div class="actions">
+        {#if treeNode.visible !== undefined}
+            <span title="Focus Node" class="icon-button" on:click|stopPropagation={focusNode}>
+                <Issues />
+            </span>
+        {/if}
+
         {#if treeNode.translation !== undefined}
             <span
                 title="Move Node Position"