Fix NumberField stepping

rokucommunity · Sep 5, 2023 · bd1e921 · bd1e921
1 parent beef781
commit bd1e921
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/webviews/src/shared/NumberField.svelte b/webviews/src/shared/NumberField.svelte
@@ -14,7 +14,7 @@
     function onInputChange() {
         value = self.control.value;
         // Triggers update to be sent to parent's on:input
-        dispatch('input', {test: self.control});
+        dispatch('input');
     }
 
     export let value = '';
@@ -26,11 +26,10 @@
     }
 
     export let title = '';
-    export let step = 10;
+    export let step = '1';
     $: {
-        // TODO needs to be looked into fixing
         if (self) {
-            self.control.step = step.toString();
+            self.control.step = step;
         }
     }
 

diff --git a/webviews/src/views/SceneGraphInspectorView/NodeDetailPage.svelte b/webviews/src/views/SceneGraphInspectorView/NodeDetailPage.svelte
@@ -41,7 +41,7 @@
         inspectNodeBaseKeyPath = null;
     }
 
-    let numberInputsStep = 1;
+    let numberInputsStep = '1';
 
     let fields = {} as {
         [key: string]: {
@@ -217,7 +217,7 @@
                 close();
                 break;
             case 'Shift':
-                numberInputsStep = 15;
+                numberInputsStep = '15';
                 break;
         }
     }
@@ -226,7 +226,7 @@
         const key = event.key;
         switch (key) {
             case 'Shift':
-                numberInputsStep = 1;
+                numberInputsStep = '1';
                 break;
         }
     }
@@ -479,15 +479,15 @@
                         {id}
                         class="xValue fieldValue"
                         title="Hold down shift to increment faster"
-                        step={id === 'scale' ? 0.1 : numberInputsStep}
+                        step={id === 'scale' ? '0.1' : numberInputsStep}
                         value={field.value[0]}
                         on:input={onVector2dFieldChange} />
                     <NumberField
                         {id}
                         class="yValue fieldValue"
                         value={field.value[1]}
                         title="Hold down shift to increment faster"
-                        step={id === 'scale' ? 0.1 : numberInputsStep}
+                        step={id === 'scale' ? '0.1' : numberInputsStep}
                         on:input={onVector2dFieldChange} />
                     {#if id !== 'scale'}
                         <vscode-button