Improvements discovered while reviewing with Bronley

rokucommunity · Sep 11, 2023 · c8991b2 · c8991b2
1 parent 1f4887d
commit c8991b2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/viewProviders/BaseWebviewViewProvider.ts b/src/viewProviders/BaseWebviewViewProvider.ts
@@ -1,6 +1,7 @@
 import * as vscode from 'vscode';
 import * as path from 'path';
 import * as fsExtra from 'fs-extra';
+import type { RequestType } from 'roku-test-automation';
 import type { AsyncSubscription, Event } from '@parcel/watcher';
 import type { ChannelPublishedEvent } from 'roku-debug';
 import { vscodeContextManager } from '../managers/VscodeContextManager';
@@ -86,7 +87,7 @@ export abstract class BaseWebviewViewProvider implements vscode.WebviewViewProvi
         }
     }
 
-    protected addMessageCommandCallback(command: string, callback: (message) => Promise<boolean>) {
+    protected addMessageCommandCallback(command: ViewProviderCommand | VscodeCommand | RequestType, callback: (message) => Promise<boolean>) {
         this.messageCommandCallbacks[command] = callback;
     }
 

diff --git a/src/viewProviders/RokuCommandsViewProvider.spec.ts b/src/viewProviders/RokuCommandsViewProvider.spec.ts
@@ -2,6 +2,7 @@ import { expect } from 'chai';
 import * as sinonImport from 'sinon';
 import { vscode } from '../mockVscode.spec';
 import { RokuCommandsViewProvider } from './RokuCommandsViewProvider';
+import { VscodeCommand } from '../commands/VscodeCommand';
 
 let Module = require('module');
 const { require: oldRequire } = Module.prototype;
@@ -52,9 +53,9 @@ describe('RokuCommandsViewProvider', () => {
 
             expect(typeof callback).to.equal('function');
             const fake = sinonImport.fake.returns(Promise.resolve(true));
-            provider['addMessageCommandCallback']('importRegistry', fake);
+            provider['addMessageCommandCallback'](VscodeCommand.rokuRegistryImportRegistry, fake);
             callback({
-                command: 'importRegistry',
+                command: VscodeCommand.rokuRegistryImportRegistry,
                 context: {}
             });
             expect(fake.calledOnce).to.be.true;

diff --git a/webviews/src/views/RokuAutomationView/RokuAutomationView.svelte b/webviews/src/views/RokuAutomationView/RokuAutomationView.svelte
@@ -84,7 +84,7 @@
     function addStep() {
         steps.push({
             type: 'sendKeyPress',
-            value: ''
+            value: 'Ok'
         });
 
         storeConfigs(steps);
@@ -143,7 +143,7 @@
         } else {
             steps = [{
                 type: 'sleep',
-                value: '4'
+                value: '8'
             }];
         }
         loading = false;
@@ -152,7 +152,6 @@
     let lastStepDate = Date.now();
     intermediary.observeEvent(ViewProviderEvent.onRokuAutomationConfigStepChange, (message) => {
         currentRunningStep = message.context.step;
-        console.log('currentRunningStep', currentRunningStep);
         if (currentRunningStep === -1) {
             // Once we finish running all current steps, update our last step date in case we want to add any more steps
             lastStepDate = Date.now();