-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighting for embedded brs in scenegraph #316
base: master
Are you sure you want to change the base?
Conversation
e9c74a4
to
cce39b0
Compare
…htscript-language into embedded-brs-in-scenegraph
6be335e
to
bb2422d
Compare
@rokucommunity/core-team What are your thoughts on merging this? I think it has the potential to take over any other xml language stuff. Should we hold off until we add xml formatting support? |
most folks I know have coding standards that prohibit embedded brs. |
Do we know if this would break tools like the Redhat xml tools? This is used by developers to get completion support for custom components in their xml. If there is a chance it could break xml tools I would hold off as developing in this style is definitely not the community norm. If anything a quick fix action or command in xml files with cdata to pull it into its own file might be more interesting to most 🤔 |
I definitely don't want to break existing workflows or plugins, so I'll do some more investigation to determine what the full impacts are. |
I concur with: do not break XML coding experience. |
a9847ff
to
7bc581e
Compare
…htscript-language into embedded-brs-in-scenegraph
Hey there! I just built a new version of the vscode extension based on 2ca89c3. You can downloaded the .vsix here and then follow these installation instructions. |
e19b04d
to
1aa9129
Compare
This adds syntax highlighting support for embedded brightscript/brighterscript code in CDATA tags within scenegraph xml files.
Before:
After:
NOTE: this might prevent xml formatters from working properly.