Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remote control on launch #503

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Enable remote control on launch #503

merged 4 commits into from
Sep 28, 2023

Conversation

iBicha
Copy link
Contributor

@iBicha iBicha commented Sep 26, 2023

Closes #475

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I have a few suggestions on the general design of the launch.json settings.

And can you add a unit test or two ensuring that the "remoteControlMode": true turns into "remoteControlMode": {...the stuff}

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/DebugConfigurationProvider.ts Outdated Show resolved Hide resolved
@iBicha
Copy link
Contributor Author

iBicha commented Sep 27, 2023

This is great! I have a few suggestions on the general design of the launch.json settings.

And can you add a unit test or two ensuring that the "remoteControlMode": true turns into "remoteControlMode": {...the stuff}

Thanks for the review - I think I got what you wanted out of this feature (I personally prefer to hit Command+K for the remote, this is why I haven't considered the different possible preferences)

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Much closer! I think it would be nicer to eliminate the boolean in the interface, so that it's just a shorthand in the config and we can more consistently interact with the activate/deactivate props downstream.

src/DebugConfigurationProvider.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/DebugConfigurationProvider.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@iBicha
Copy link
Contributor Author

iBicha commented Sep 28, 2023

Hey! Much closer! I think it would be nicer to eliminate the boolean in the interface, so that it's just a shorthand in the config and we can more consistently interact with the activate/deactivate props downstream.

That's a good idea, I applied your suggestions

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. Thanks for this!

@TwitchBronBron TwitchBronBron merged commit 5f9e0c7 into rokucommunity:master Sep 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add launch setting to manage Remote Control Mode
2 participants