Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-enable debug protocol on 12.5 devices #517

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Nov 6, 2023

Auto-enables the debug protocol for any launch to a 12.5 devices that doesn't explicitly have enableDebugProtocol defined.

We intend on running this as a trial period for a week to see what issues are uncovered. If the test goes smoothly, we'll leave this feature enabled indefinitely. If issues are discovered, we'll disable the protocol until we can fix the issues and then try again in the future. The goal of this is to tell the user we've enabled the protocol, but still give them an option for using telnet instead. However, it's in the user's best interest to give the debug protocol a thorough test, because it will become the default debug mode in the near future.

Users are presented with this popup:

image

Then after 2 clicks of the "Use telnet" button, we switch to this so the user can hide the popup for 12 hours.
image

here's the "report issue" dialog:
image

@TwitchBronBron TwitchBronBron merged commit 49e6b7e into master Nov 6, 2023
5 checks passed
@TwitchBronBron TwitchBronBron deleted the enable-debug-protocol-by-default branch November 6, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant