Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the debug protocol popup, telnet by default #530

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Hide the debug protocol popup, telnet by default #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/DebugConfigurationProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ export class BrightScriptDebugConfigurationProvider implements DebugConfiguratio
throw new Error(`Cannot deploy: developer mode is disabled on '${result.host}'`);
}

result = await this.processEnableDebugProtocolParameter(result, deviceInfo);
//TODO re-enable once we've fixed some of the debug protocol issues
// result = await this.processEnableDebugProtocolParameter(result, deviceInfo);

result.enableDebugProtocol ??= this.configDefaults.enableDebugProtocol;

await this.context.workspaceState.update('enableDebuggerAutoRecovery', result.enableDebuggerAutoRecovery);

Expand All @@ -132,7 +135,7 @@ export class BrightScriptDebugConfigurationProvider implements DebugConfiguratio
}
}

private async processEnableDebugProtocolParameter(config: BrightScriptLaunchConfiguration, deviceInfo: DeviceInfo) {
protected async processEnableDebugProtocolParameter(config: BrightScriptLaunchConfiguration, deviceInfo: DeviceInfo) {
if (config.enableDebugProtocol !== undefined || !semver.gte(deviceInfo?.softwareVersion ?? '0.0.0', '12.5.0')) {
config.enableDebugProtocol = config.enableDebugProtocol ? true : false;
return config;
Expand Down